Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize statsGuard_ on LogErrorEventFilter #44447

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

makortel
Copy link
Contributor

PR description:

I found statsGuard_ being uninitialized while running valgrind a workflow mentioned in #44413. This fix might address those failures.

PR validation:

Valgrind warning is gone.

Hopefully this fixes the segfaults seeing in this module in IBs.
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 18, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44447/39517

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • DPGAnalysis/Skims (pdmv)

@sunilUIET, @miquork, @AdrianoDee, @cmsbuild can you please review it and eventually sign? Thanks.
@youyingli, @AnnikaStein this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fbc8d8/38210/summary.html
COMMIT: 9a49f82
CMSSW: CMSSW_14_1_X_2024-03-17-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44447/38210/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@makortel
Copy link
Contributor Author

@cms-sw/pdmv-l2 Could you review and sign?

@sunilUIET
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants